| | | 1 | | using System.Collections.Concurrent; |
| | | 2 | | using System.Collections.Immutable; |
| | | 3 | | |
| | | 4 | | using Microsoft.CodeAnalysis; |
| | | 5 | | using Microsoft.CodeAnalysis.CSharp; |
| | | 6 | | using Microsoft.CodeAnalysis.CSharp.Syntax; |
| | | 7 | | using Microsoft.CodeAnalysis.Diagnostics; |
| | | 8 | | |
| | | 9 | | using NexusLabs.Needlr.Roslyn.Shared; |
| | | 10 | | |
| | | 11 | | namespace NexusLabs.Needlr.Analyzers; |
| | | 12 | | |
| | | 13 | | /// <summary> |
| | | 14 | | /// Analyzer that detects IEnumerable<T> dependencies where no implementations of T |
| | | 15 | | /// are discovered by source generation. Only active when [assembly: GenerateTypeRegistry] is present. |
| | | 16 | | /// </summary> |
| | | 17 | | [DiagnosticAnalyzer(LanguageNames.CSharp)] |
| | | 18 | | public sealed class CollectionResolutionAnalyzer : DiagnosticAnalyzer |
| | | 19 | | { |
| | | 20 | | private const string GenerateTypeRegistryAttributeName = "NexusLabs.Needlr.Generators.GenerateTypeRegistryAttribute" |
| | | 21 | | |
| | | 22 | | public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => |
| | 123 | 23 | | ImmutableArray.Create(DiagnosticDescriptors.CollectionResolutionEmpty); |
| | | 24 | | |
| | | 25 | | public override void Initialize(AnalysisContext context) |
| | | 26 | | { |
| | 16 | 27 | | context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); |
| | 16 | 28 | | context.EnableConcurrentExecution(); |
| | | 29 | | |
| | 16 | 30 | | context.RegisterCompilationStartAction(compilationContext => |
| | 16 | 31 | | { |
| | 9 | 32 | | if (!HasGenerateTypeRegistryAttribute(compilationContext.Compilation)) |
| | 1 | 33 | | return; |
| | 16 | 34 | | |
| | 8 | 35 | | var enumerableType = compilationContext.Compilation.GetTypeByMetadataName("System.Collections.Generic.IEnume |
| | 8 | 36 | | if (enumerableType == null) |
| | 0 | 37 | | return; |
| | 16 | 38 | | |
| | 16 | 39 | | // Collect all discovered interface implementations during compilation |
| | 8 | 40 | | var discoveredInterfaces = new ConcurrentDictionary<INamedTypeSymbol, byte>(SymbolEqualityComparer.Default); |
| | 16 | 41 | | |
| | 16 | 42 | | // Collect pending diagnostics to verify at compilation end |
| | 8 | 43 | | var pendingDiagnostics = new ConcurrentBag<(Location Location, INamedTypeSymbol InnerType)>(); |
| | 16 | 44 | | |
| | 16 | 45 | | // First pass: collect all interfaces that have implementations |
| | 8 | 46 | | compilationContext.RegisterSymbolAction(symbolContext => |
| | 8 | 47 | | { |
| | 77 | 48 | | var typeSymbol = (INamedTypeSymbol)symbolContext.Symbol; |
| | 8 | 49 | | |
| | 77 | 50 | | if (!IsDiscoverableClass(typeSymbol)) |
| | 65 | 51 | | return; |
| | 8 | 52 | | |
| | 30 | 53 | | foreach (var iface in typeSymbol.AllInterfaces) |
| | 8 | 54 | | { |
| | 3 | 55 | | discoveredInterfaces.TryAdd(iface, 0); |
| | 8 | 56 | | } |
| | 20 | 57 | | }, SymbolKind.NamedType); |
| | 16 | 58 | | |
| | 16 | 59 | | // Second pass: collect IEnumerable<T> parameters for later verification |
| | 8 | 60 | | compilationContext.RegisterSyntaxNodeAction( |
| | 16 | 61 | | ctx => CollectEnumerableParameter(ctx, enumerableType, pendingDiagnostics), |
| | 8 | 62 | | SyntaxKind.Parameter); |
| | 16 | 63 | | |
| | 16 | 64 | | // At compilation end, verify and report diagnostics |
| | 8 | 65 | | compilationContext.RegisterCompilationEndAction(endContext => |
| | 8 | 66 | | { |
| | 30 | 67 | | foreach (var (location, innerType) in pendingDiagnostics) |
| | 8 | 68 | | { |
| | 8 | 69 | | // Framework interfaces are typically populated by the framework |
| | 7 | 70 | | var ns = innerType.ContainingNamespace?.ToDisplayString() ?? ""; |
| | 7 | 71 | | if (ns.StartsWith("Microsoft.Extensions.") || |
| | 7 | 72 | | ns.StartsWith("Microsoft.AspNetCore.") || |
| | 7 | 73 | | ns == "System" || |
| | 7 | 74 | | ns.StartsWith("System.")) |
| | 8 | 75 | | { |
| | 8 | 76 | | continue; |
| | 8 | 77 | | } |
| | 8 | 78 | | |
| | 8 | 79 | | // Check if we discovered any implementations |
| | 6 | 80 | | if (discoveredInterfaces.ContainsKey(innerType)) |
| | 8 | 81 | | continue; |
| | 8 | 82 | | |
| | 4 | 83 | | var diagnostic = Diagnostic.Create( |
| | 4 | 84 | | DiagnosticDescriptors.CollectionResolutionEmpty, |
| | 4 | 85 | | location, |
| | 4 | 86 | | innerType.Name); |
| | 8 | 87 | | |
| | 4 | 88 | | endContext.ReportDiagnostic(diagnostic); |
| | 8 | 89 | | } |
| | 16 | 90 | | }); |
| | 24 | 91 | | }); |
| | 16 | 92 | | } |
| | | 93 | | |
| | | 94 | | private static bool HasGenerateTypeRegistryAttribute(Compilation compilation) |
| | | 95 | | { |
| | 26 | 96 | | foreach (var attribute in compilation.Assembly.GetAttributes()) |
| | | 97 | | { |
| | 8 | 98 | | var fullName = attribute.AttributeClass?.ToDisplayString(); |
| | 8 | 99 | | if (fullName == GenerateTypeRegistryAttributeName) |
| | 8 | 100 | | return true; |
| | | 101 | | } |
| | | 102 | | |
| | 1 | 103 | | return false; |
| | | 104 | | } |
| | | 105 | | |
| | | 106 | | private static void CollectEnumerableParameter( |
| | | 107 | | SyntaxNodeAnalysisContext context, |
| | | 108 | | INamedTypeSymbol enumerableType, |
| | | 109 | | ConcurrentBag<(Location, INamedTypeSymbol)> pendingDiagnostics) |
| | | 110 | | { |
| | 16 | 111 | | var parameter = (ParameterSyntax)context.Node; |
| | 16 | 112 | | if (parameter.Type == null) |
| | 0 | 113 | | return; |
| | | 114 | | |
| | 16 | 115 | | var typeInfo = context.SemanticModel.GetTypeInfo(parameter.Type); |
| | 16 | 116 | | if (typeInfo.Type is not INamedTypeSymbol parameterType) |
| | 0 | 117 | | return; |
| | | 118 | | |
| | 16 | 119 | | if (!SymbolEqualityComparer.Default.Equals(parameterType.OriginalDefinition, enumerableType)) |
| | 8 | 120 | | return; |
| | | 121 | | |
| | 8 | 122 | | if (parameterType.TypeArguments.Length != 1) |
| | 0 | 123 | | return; |
| | | 124 | | |
| | 8 | 125 | | var innerType = parameterType.TypeArguments[0] as INamedTypeSymbol; |
| | 8 | 126 | | if (innerType == null) |
| | 0 | 127 | | return; |
| | | 128 | | |
| | | 129 | | // Only warn for interface types - concrete types in IEnumerable<T> are unusual |
| | 8 | 130 | | if (innerType.TypeKind != TypeKind.Interface) |
| | 1 | 131 | | return; |
| | | 132 | | |
| | 7 | 133 | | pendingDiagnostics.Add((parameter.Type.GetLocation(), innerType)); |
| | 7 | 134 | | } |
| | | 135 | | |
| | | 136 | | /// <summary> |
| | | 137 | | /// Uses the shared TypeDiscoveryHelper to determine if a type is discoverable. |
| | | 138 | | /// This ensures consistency with the source generator's logic. |
| | | 139 | | /// </summary> |
| | | 140 | | private static bool IsDiscoverableClass(INamedTypeSymbol classSymbol) |
| | 77 | 141 | | => TypeDiscoveryHelper.IsInjectableType(classSymbol, isCurrentAssembly: true); |
| | | 142 | | } |